diff options
| author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-06-12 09:46:26 +0800 |
|---|---|---|
| committer | Anton Vorontsov <cbouatmailru@gmail.com> | 2012-06-17 20:19:59 -0700 |
| commit | 92311c3c70f9b7f1b7860c2fc2ada09b4d43bfea (patch) | |
| tree | 5fdcf24cdc4d9419b7802f29963de6ee9388caa6 /drivers/power | |
| parent | 485802a6c524e62b5924849dd727ddbb1497cc71 (diff) | |
| download | op-kernel-dev-92311c3c70f9b7f1b7860c2fc2ada09b4d43bfea.zip op-kernel-dev-92311c3c70f9b7f1b7860c2fc2ada09b4d43bfea.tar.gz | |
pda_power: Complain if regulator operations fail
Rather than silently ignoring errors from the regulator enable and disable
add a WARN_ON() - it's probably pretty important if we're not getting
power, though it should be vanishingly unlikely in production.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Diffstat (limited to 'drivers/power')
| -rw-r--r-- | drivers/power/pda_power.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c index 214468f..ed54a35 100644 --- a/drivers/power/pda_power.c +++ b/drivers/power/pda_power.c @@ -134,13 +134,13 @@ static void update_charger(void) regulator_set_current_limit(ac_draw, max_uA, max_uA); if (!regulator_enabled) { dev_dbg(dev, "charger on (AC)\n"); - regulator_enable(ac_draw); + WARN_ON(regulator_enable(ac_draw)); regulator_enabled = 1; } } else { if (regulator_enabled) { dev_dbg(dev, "charger off\n"); - regulator_disable(ac_draw); + WARN_ON(regulator_disable(ac_draw)); regulator_enabled = 0; } } |
