summaryrefslogtreecommitdiffstats
path: root/drivers/power/jz4740-battery.c
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2011-12-08 21:05:26 +0800
committerAnton Vorontsov <cbouatmailru@gmail.com>2012-01-06 05:57:17 +0400
commitef7906f3204280ccaf8cd7ace974b7c0a1393812 (patch)
tree125e5f8240ae635a3ff5665f8ad488c170de2228 /drivers/power/jz4740-battery.c
parent2530daa187be3adef2d7cb41bd51f1384e478f2b (diff)
downloadop-kernel-dev-ef7906f3204280ccaf8cd7ace974b7c0a1393812.zip
op-kernel-dev-ef7906f3204280ccaf8cd7ace974b7c0a1393812.tar.gz
jz4740-battery: Fix signedness bug
wait_for_completion_interruptible_timeout() may return negative value. In this case, checking if (t > 0) will return true if t is unsigned. Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Diffstat (limited to 'drivers/power/jz4740-battery.c')
-rw-r--r--drivers/power/jz4740-battery.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 6b77029..8dbc7bf 100644
--- a/drivers/power/jz4740-battery.c
+++ b/drivers/power/jz4740-battery.c
@@ -67,7 +67,7 @@ static irqreturn_t jz_battery_irq_handler(int irq, void *devid)
static long jz_battery_read_voltage(struct jz_battery *battery)
{
- unsigned long t;
+ long t;
unsigned long val;
long voltage;
OpenPOWER on IntegriCloud