summaryrefslogtreecommitdiffstats
path: root/drivers/power/ab8500_fg.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2012-08-19 10:44:21 +0200
committerAnton Vorontsov <anton.vorontsov@linaro.org>2012-08-22 18:48:01 -0700
commitd2941651d754fa04eebd0bba70d558424d838565 (patch)
tree164d38d613bedcdb4b34f5aecf9e6609b0365b14 /drivers/power/ab8500_fg.c
parent05cdbdb95f98fcd080e7494f7d0ca4886aed3c64 (diff)
downloadop-kernel-dev-d2941651d754fa04eebd0bba70d558424d838565.zip
op-kernel-dev-d2941651d754fa04eebd0bba70d558424d838565.tar.gz
ab8500_fg: Fix error return code
Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'drivers/power/ab8500_fg.c')
-rw-r--r--drivers/power/ab8500_fg.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index bf02225..11633e3 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -2506,6 +2506,7 @@ static int __devinit ab8500_fg_probe(struct platform_device *pdev)
di->fg_wq = create_singlethread_workqueue("ab8500_fg_wq");
if (di->fg_wq == NULL) {
dev_err(di->dev, "failed to create work queue\n");
+ ret = -ENOMEM;
goto free_device_info;
}
OpenPOWER on IntegriCloud