diff options
| author | Joe Perches <joe@perches.com> | 2015-08-26 11:13:38 -0700 |
|---|---|---|
| committer | Darren Hart <dvhart@linux.intel.com> | 2015-08-28 10:49:52 -0700 |
| commit | efd85cf86a56898686187397adfd52dfac79aff2 (patch) | |
| tree | 41c940cf0d3c10b23d4e7045ef77cdebb2bc9e75 /drivers/platform/x86/thinkpad_acpi.c | |
| parent | 2508a45a924dfa4a5f6e60675aa4732d888134a7 (diff) | |
| download | op-kernel-dev-efd85cf86a56898686187397adfd52dfac79aff2.zip op-kernel-dev-efd85cf86a56898686187397adfd52dfac79aff2.tar.gz | |
thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro
vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses
no_printk which produces no logging output but always
evaluates arguments.
Change the macro to surround the no_printk call with
do { if (0) no_printk(...); } while (0)
to avoid the unnecessary argument evaluations.
$ size drivers/platform/x86/thinkpad_acpi.o*
text data bss dec hex filename
60918 6184 824 67926 10956 drivers/platform/x86/thinkpad_acpi.o.new
60927 6184 824 67935 1095f drivers/platform/x86/thinkpad_acpi.o.old
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Diffstat (limited to 'drivers/platform/x86/thinkpad_acpi.c')
| -rw-r--r-- | drivers/platform/x86/thinkpad_acpi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 33e488c..131dd74 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -402,7 +402,7 @@ static const char *str_supported(int is_supported); #else static inline const char *str_supported(int is_supported) { return ""; } #define vdbg_printk(a_dbg_level, format, arg...) \ - no_printk(format, ##arg) + do { if (0) no_printk(format, ##arg); } while (0) #endif static void tpacpi_log_usertask(const char * const what) |
