summaryrefslogtreecommitdiffstats
path: root/drivers/platform/goldfish
diff options
context:
space:
mode:
authorAlan Cox <alan@linux.intel.com>2013-01-23 14:13:18 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-24 13:51:38 -0800
commit17c4c9db4a33ae0a8dcfafab3dc59a83ccaf6076 (patch)
tree81d55fa14f114cf3d8e12d080032441e4fb0bce1 /drivers/platform/goldfish
parentc89f2750e9845aa115ca30c062edd569da619cad (diff)
downloadop-kernel-dev-17c4c9db4a33ae0a8dcfafab3dc59a83ccaf6076.zip
op-kernel-dev-17c4c9db4a33ae0a8dcfafab3dc59a83ccaf6076.tar.gz
goldfish: Add a FIXME note to the pipe driver
Note a point in the pipe driver that wants future attention Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/platform/goldfish')
-rw-r--r--drivers/platform/goldfish/goldfish_pipe.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 58dae1f..4f5aa831 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -300,6 +300,7 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
int status, wakeBit;
/* Ensure that the corresponding page is properly mapped */
+ /* FIXME: this isn't safe or sufficient - use get_user_pages */
if (is_write) {
char c;
/* Ensure that the page is mapped and readable */
OpenPOWER on IntegriCloud