summaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/bcm
diff options
context:
space:
mode:
authorStefan Wahren <stefan.wahren@i2se.com>2017-06-21 20:20:04 +0200
committerLinus Walleij <linus.walleij@linaro.org>2017-06-29 11:04:38 +0200
commit37a2f8e5522abd8e206a0da1622034382aa6683d (patch)
tree096add70a153036b838c189f35002c7599b723a0 /drivers/pinctrl/bcm
parenta66f9d93c18b37ac1a9a8fb710a5369b30a2f290 (diff)
downloadop-kernel-dev-37a2f8e5522abd8e206a0da1622034382aa6683d.zip
op-kernel-dev-37a2f8e5522abd8e206a0da1622034382aa6683d.tar.gz
pinctrl: bcm2835: Avoid warning from __irq_do_set_handler
We get a warning during boot with enabled EARLY_PRINTK that we try to set a irq_chip without data. This is caused by ignoring the return value of irq_of_parse_and_map(). So avoid calling gpiochip_set_chained_irqchip() in error case. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP") Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/bcm')
-rw-r--r--drivers/pinctrl/bcm/pinctrl-bcm2835.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 1eb7a1a..2308831 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -1048,6 +1048,10 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev)
for (i = 0; i < BCM2835_NUM_IRQS; i++) {
pc->irq[i] = irq_of_parse_and_map(np, i);
pc->irq_group[i] = i;
+
+ if (pc->irq[i] == 0)
+ continue;
+
/*
* Use the same handler for all groups: this is necessary
* since we use one gpiochip to cover all lines - the
OpenPOWER on IntegriCloud