summaryrefslogtreecommitdiffstats
path: root/drivers/phy
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2014-02-17 14:29:24 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-18 12:13:16 -0800
commitb51fbf9fb0c32c1a98f824ab5d6f59b17b39ef9e (patch)
treeb3c4488e3c625973288f4eb663a7e92a25de48e3 /drivers/phy
parent767a1b5d6ec4ac5335dde17100880347ed154ce2 (diff)
downloadop-kernel-dev-b51fbf9fb0c32c1a98f824ab5d6f59b17b39ef9e.zip
op-kernel-dev-b51fbf9fb0c32c1a98f824ab5d6f59b17b39ef9e.tar.gz
phy-core: Don't allow building phy-core as a module
include/phy/phy.h has stub code in there for when building without the phy-core enabled. This is useful for generic drivers such as ahci-platform, ehci-platoform and ohci-platform which have support for driving an optional phy passed to them through the devicetree. Since on some boards this phy functionality is not needed, being able to disable the phy subsystem without needing a lot of #ifdef magic in the driver using it is quite useful. However this breaks when the module using the phy subsystem is build-in and the phy-core is not, which leads to the build failing with missing symbol errors in the linking stage of the zImage. Which leads to gems such as this being added to the Kconfig for achi_platform: depends on GENERIC_PHY || !GENERIC_PHY Rather then duplicating this code in a lot of places using the phy-core, I believe it is better to simply not allow the phy-core to be built as a module. The phy core is quite small and has no external dependencies, so always building it in when enabling it should not be an issue. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Roger Quadros <rogerq@ti.com> Acked-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/phy')
-rw-r--r--drivers/phy/Kconfig2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 79e3c70..c7a551c 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -5,7 +5,7 @@
menu "PHY Subsystem"
config GENERIC_PHY
- tristate "PHY Core"
+ bool "PHY Core"
help
Generic PHY support.
OpenPOWER on IntegriCloud