summaryrefslogtreecommitdiffstats
path: root/drivers/pcmcia
diff options
context:
space:
mode:
authorWolfram Sang <w.sang@pengutronix.de>2009-07-29 14:25:37 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2009-09-15 10:17:16 -0700
commit889c27744c30eb7a43b68c11e33e679cfafc8cd5 (patch)
treea23fa04617b0511aee826a9f7d782d56c4335c28 /drivers/pcmcia
parentcb6dbd79628a53e66352387b53b426fa88640bfe (diff)
downloadop-kernel-dev-889c27744c30eb7a43b68c11e33e679cfafc8cd5.zip
op-kernel-dev-889c27744c30eb7a43b68c11e33e679cfafc8cd5.tar.gz
pcmcia: document return value of pcmcia_loop_config
Hopefully it will be harder to get it wrong now. Also fix an unneeded initialization while we are here. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/pcmcia')
-rw-r--r--drivers/pcmcia/pcmcia_resource.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
index 8c2db2a..d919e96 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -902,7 +902,7 @@ struct pcmcia_cfg_mem {
*
* pcmcia_loop_config() loops over all configuration options, and calls
* the driver-specific conf_check() for each one, checking whether
- * it is a valid one.
+ * it is a valid one. Returns 0 on success or errorcode otherwise.
*/
int pcmcia_loop_config(struct pcmcia_device *p_dev,
int (*conf_check) (struct pcmcia_device *p_dev,
@@ -915,7 +915,7 @@ int pcmcia_loop_config(struct pcmcia_device *p_dev,
struct pcmcia_cfg_mem *cfg_mem;
tuple_t *tuple;
- int ret = -ENODEV;
+ int ret;
unsigned int vcc;
cfg_mem = kzalloc(sizeof(struct pcmcia_cfg_mem), GFP_KERNEL);
OpenPOWER on IntegriCloud