diff options
| author | Dominik Brodowski <linux@dominikbrodowski.net> | 2008-06-14 18:51:06 +0200 |
|---|---|---|
| committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2008-06-24 15:33:41 +0200 |
| commit | c1ac02280d76de7aba8a9d43638d0f7d1fd0f820 (patch) | |
| tree | 5953c5979844bd06b9d818418febb657be3596dc /drivers/pcmcia/pcmcia_resource.c | |
| parent | 4cf974c57633e70a8d48f9d40e41cf192c6e062c (diff) | |
| download | op-kernel-dev-c1ac02280d76de7aba8a9d43638d0f7d1fd0f820.zip op-kernel-dev-c1ac02280d76de7aba8a9d43638d0f7d1fd0f820.tar.gz | |
pcmcia: check for pointer instead of pointer address
Bug noted by Michael Buesch: checking for the pointer address is always true.
This didn't matter much, for the very first check in pcmcia_release_window()
was for the pointer pointing to something, and the return value is ignored
here. Nonetheless, fix it.
CC: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/pcmcia/pcmcia_resource.c')
| -rw-r--r-- | drivers/pcmcia/pcmcia_resource.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c index 1d128fb..c8f77b8 100644 --- a/drivers/pcmcia/pcmcia_resource.c +++ b/drivers/pcmcia/pcmcia_resource.c @@ -966,7 +966,7 @@ void pcmcia_disable_device(struct pcmcia_device *p_dev) { pcmcia_release_configuration(p_dev); pcmcia_release_io(p_dev, &p_dev->io); pcmcia_release_irq(p_dev, &p_dev->irq); - if (&p_dev->win) + if (p_dev->win) pcmcia_release_window(p_dev->win); } EXPORT_SYMBOL(pcmcia_disable_device); |
