diff options
| author | David Vrabel <david.vrabel@citrix.com> | 2012-10-18 11:03:36 +0100 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2012-11-30 14:33:35 -0700 |
| commit | d5af64de2d1cc87d77ac7c0e90d89630a37a4f09 (patch) | |
| tree | d1fe66a02d41848614c39adde978ca1fcd08cf25 /drivers/pci | |
| parent | 918b4053184c0ca22236e70e299c5343eea35304 (diff) | |
| download | op-kernel-dev-d5af64de2d1cc87d77ac7c0e90d89630a37a4f09.zip op-kernel-dev-d5af64de2d1cc87d77ac7c0e90d89630a37a4f09.tar.gz | |
xen-pcifront: Handle backend CLOSED without CLOSING
Backend drivers shouldn't transition to CLOSED unless the frontend is
CLOSED. If a backend does transition to CLOSED too soon then the
frontend may not see the CLOSING state and will not properly shutdown.
So, treat an unexpected backend CLOSED state the same as CLOSING.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/xen-pcifront.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index 0aab85a..a0c7312 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -1068,13 +1068,16 @@ static void __init_refok pcifront_backend_changed(struct xenbus_device *xdev, case XenbusStateInitialising: case XenbusStateInitWait: case XenbusStateInitialised: - case XenbusStateClosed: break; case XenbusStateConnected: pcifront_try_connect(pdev); break; + case XenbusStateClosed: + if (xdev->state == XenbusStateClosed) + break; + /* Missed the backend's CLOSING state -- fallthrough */ case XenbusStateClosing: dev_warn(&xdev->dev, "backend going away!\n"); pcifront_try_disconnect(pdev); |
