summaryrefslogtreecommitdiffstats
path: root/drivers/pci
diff options
context:
space:
mode:
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>2008-05-08 14:37:25 +0900
committerJesse Barnes <jbarnes@virtuousgeek.org>2008-05-13 09:51:53 -0700
commit21e2b0a5efb3a01de58e7cb630f2eb70894da352 (patch)
tree7bf83b7fa2de1c10defdbcac59bf626ffbb87fcd /drivers/pci
parentc714a534d85576af21b06be605ca55cb2fb887ee (diff)
downloadop-kernel-dev-21e2b0a5efb3a01de58e7cb630f2eb70894da352.zip
op-kernel-dev-21e2b0a5efb3a01de58e7cb630f2eb70894da352.tar.gz
PCI ACPI: fix uninitialized variable in __pci_osc_support_set
Fix uninitialized variable in __pci_osc_support_set(). If the ACPI namespace doesn't have any device object corresponding to the specified hid, 'retval' in __pci_osc_support_set() is not changed by the acpi_query_osc() callback. Since 'retval' is not initizlized in the current implementation, the contents of 'retval' is undefined in this case. This causes a mis-handling of ctrlset_buf[OSC_SUPPORT_TYPE] and will cause an unexpected result in the subsequent pci_osc_control_set() call as a result. Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci')
-rw-r--r--drivers/pci/pci-acpi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 72f7476..ddfd756 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -166,7 +166,7 @@ run_osc_out:
acpi_status __pci_osc_support_set(u32 flags, const char *hid)
{
u32 temp;
- acpi_status retval;
+ acpi_status retval = AE_NOT_FOUND;
if (!(flags & OSC_SUPPORT_MASKS)) {
return AE_TYPE;
OpenPOWER on IntegriCloud