diff options
| author | Zhang Yanmin <yanmin.zhang@intel.com> | 2006-06-02 12:35:43 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-06-21 12:00:01 -0700 |
| commit | d71374dafbba7ec3f67371d3b7e9f6310a588808 (patch) | |
| tree | 116dcd65fde3701d10fea954cdbd5bb063182b2c /drivers/pci/pci.h | |
| parent | 733a7fe12248072e1bca729c88a26298666f1956 (diff) | |
| download | op-kernel-dev-d71374dafbba7ec3f67371d3b7e9f6310a588808.zip op-kernel-dev-d71374dafbba7ec3f67371d3b7e9f6310a588808.tar.gz | |
[PATCH] PCI: fix race with pci_walk_bus and pci_destroy_dev
pci_walk_bus has a race with pci_destroy_dev. When cb is called
in pci_walk_bus, pci_destroy_dev might unlink the dev pointed by next.
Later on in the next loop, pointer next becomes NULL and cause
kernel panic.
Below patch against 2.6.17-rc4 fixes it by changing pci_bus_lock (spin_lock)
to pci_bus_sem (rw_semaphore).
Signed-off-by: Zhang Yanmin <yanmin.zhang@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/pci/pci.h')
| -rw-r--r-- | drivers/pci/pci.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 30630cb..29bdeca 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -40,7 +40,7 @@ extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int extern void pci_remove_legacy_files(struct pci_bus *bus); /* Lock for read/write access to pci device and bus lists */ -extern spinlock_t pci_bus_lock; +extern struct rw_semaphore pci_bus_sem; #ifdef CONFIG_X86_IO_APIC extern int pci_msi_quirk; |
