diff options
| author | Prarit Bhargava <prarit@redhat.com> | 2010-05-17 14:25:14 -0400 |
|---|---|---|
| committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2010-05-18 15:00:25 -0700 |
| commit | 5030718ee465c759c2a851851e79039f58b9efb3 (patch) | |
| tree | dedfe6c7866cf19e3555662ceaa8782454e9338c /drivers/pci/access.c | |
| parent | ee6583f6e8f8dad4a53985dbabcd7c242d66a6b6 (diff) | |
| download | op-kernel-dev-5030718ee465c759c2a851851e79039f58b9efb3.zip op-kernel-dev-5030718ee465c759c2a851851e79039f58b9efb3.tar.gz | |
PCI: output FW warning in pci_read/write_vpd
pci_read/write_vpd() can fail due to a timeout. Usually the command
times out because of firmware issues (incorrect vpd length, etc.) on the
PCI card. Currently, the timeout occurs silently.
Output a message to the user indicating that they should check with
their vendor for new firmware.
Reviewed-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci/access.c')
| -rw-r--r-- | drivers/pci/access.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/pci/access.c b/drivers/pci/access.c index affb83b..531bc69 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -220,8 +220,13 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev) return 0; } - if (time_after(jiffies, timeout)) + if (time_after(jiffies, timeout)) { + dev_printk(KERN_DEBUG, &dev->dev, + "vpd r/w failed. This is likely a firmware " + "bug on this device. Contact the card " + "vendor for a firmware update."); return -ETIMEDOUT; + } if (fatal_signal_pending(current)) return -EINTR; if (!cond_resched()) |
