summaryrefslogtreecommitdiffstats
path: root/drivers/nfc
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-04-05 14:06:36 +0200
committerSamuel Ortiz <sameo@linux.intel.com>2015-04-06 01:22:17 +0200
commit5df848f37b1d20e5dd64bea16ba9f69ed321e11b (patch)
treeb335afa0e47f47ea547035b9bb416de0bfcb42f7 /drivers/nfc
parent9421ce10ad87f799263bddad74b91e2166f020a1 (diff)
downloadop-kernel-dev-5df848f37b1d20e5dd64bea16ba9f69ed321e11b.zip
op-kernel-dev-5df848f37b1d20e5dd64bea16ba9f69ed321e11b.tar.gz
NFC: pn533: fix error return code
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/nfc')
-rw-r--r--drivers/nfc/pn533.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/nfc/pn533.c b/drivers/nfc/pn533.c
index d46a700a..732e607 100644
--- a/drivers/nfc/pn533.c
+++ b/drivers/nfc/pn533.c
@@ -2554,8 +2554,10 @@ static int pn533_data_exchange_complete(struct pn533 *dev, void *_arg,
}
skb = pn533_build_response(dev);
- if (!skb)
+ if (!skb) {
+ rc = -ENOMEM;
goto error;
+ }
arg->cb(arg->cb_context, skb, 0);
kfree(arg);
OpenPOWER on IntegriCloud