diff options
| author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-01-20 23:32:56 +0300 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@pobox.com> | 2006-01-26 22:09:40 -0500 |
| commit | 6f9d47220eb2d1b17a0a3ecaf1b564ff95b8393d (patch) | |
| tree | 956eced6edc00738c1a4919f17e272e9db3d0fd9 /drivers/net | |
| parent | 6a986ce45d45b099ddf676c340267765e76db91e (diff) | |
| download | op-kernel-dev-6f9d47220eb2d1b17a0a3ecaf1b564ff95b8393d.zip op-kernel-dev-6f9d47220eb2d1b17a0a3ecaf1b564ff95b8393d.tar.gz | |
[PATCH] acenic: fix checking of read_eeprom_byte() return values
tmp in ace_init is u32 thus rendering read_eeprom_byte() return values
checks useless.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/acenic.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c index b8953de..b508812 100644 --- a/drivers/net/acenic.c +++ b/drivers/net/acenic.c @@ -1002,6 +1002,8 @@ static int __devinit ace_init(struct net_device *dev) mac1 = 0; for(i = 0; i < 4; i++) { + int tmp; + mac1 = mac1 << 8; tmp = read_eeprom_byte(dev, 0x8c+i); if (tmp < 0) { @@ -1012,6 +1014,8 @@ static int __devinit ace_init(struct net_device *dev) } mac2 = 0; for(i = 4; i < 8; i++) { + int tmp; + mac2 = mac2 << 8; tmp = read_eeprom_byte(dev, 0x8c+i); if (tmp < 0) { |
