diff options
| author | Wei Liu <wei.liu2@citrix.com> | 2013-10-28 12:07:57 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-10-29 00:24:49 -0400 |
| commit | 059dfa6a93b779516321e5112db9d7621b1367ba (patch) | |
| tree | 9d8923e95ae5323bcadb17cbf1ee5f57bc9cebbd /drivers/net/xen-netback/common.h | |
| parent | 262e827fe745642589450ae241b7afd3912c3f25 (diff) | |
| download | op-kernel-dev-059dfa6a93b779516321e5112db9d7621b1367ba.zip op-kernel-dev-059dfa6a93b779516321e5112db9d7621b1367ba.tar.gz | |
xen-netback: use jiffies_64 value to calculate credit timeout
time_after_eq() only works if the delta is < MAX_ULONG/2.
For a 32bit Dom0, if netfront sends packets at a very low rate, the time
between subsequent calls to tx_credit_exceeded() may exceed MAX_ULONG/2
and the test for timer_after_eq() will be incorrect. Credit will not be
replenished and the guest may become unable to send packets (e.g., if
prior to the long gap, all credit was exhausted).
Use jiffies_64 variant to mitigate this problem for 32bit Dom0.
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Jason Luan <jianhai.luan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netback/common.h')
| -rw-r--r-- | drivers/net/xen-netback/common.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 5715318..400fea1 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -163,6 +163,7 @@ struct xenvif { unsigned long credit_usec; unsigned long remaining_credit; struct timer_list credit_timeout; + u64 credit_window_start; /* Statistics */ unsigned long rx_gso_checksum_fixup; |
