summaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-03-15 10:01:58 +0300
committerJohn W. Linville <linville@tuxdriver.com>2011-03-21 15:17:14 -0400
commitf8a22a2b165c79a46e275097fcadab7fd151c504 (patch)
tree633673896dd5d4feac2e2c99818eb885c5d9c55d /drivers/net/wireless
parent9011cd250e26d9159943895adf29453af1b93298 (diff)
downloadop-kernel-dev-f8a22a2b165c79a46e275097fcadab7fd151c504.zip
op-kernel-dev-f8a22a2b165c79a46e275097fcadab7fd151c504.tar.gz
iwlwifi: missing unlock on error path
We should unlock here instead of returning -EINVAL directly. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless')
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-agn.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 581dc9f..321b18b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -3009,14 +3009,17 @@ static int iwl_mac_offchannel_tx_cancel_wait(struct ieee80211_hw *hw)
mutex_lock(&priv->mutex);
- if (!priv->_agn.offchan_tx_skb)
- return -EINVAL;
+ if (!priv->_agn.offchan_tx_skb) {
+ ret = -EINVAL;
+ goto unlock;
+ }
priv->_agn.offchan_tx_skb = NULL;
ret = iwl_scan_cancel_timeout(priv, 200);
if (ret)
ret = -EIO;
+unlock:
mutex_unlock(&priv->mutex);
return ret;
OpenPOWER on IntegriCloud