diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-06-14 00:26:11 +0400 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2013-06-14 13:37:16 -0400 |
| commit | 1105a13bb8ad29cf83d46989ee462d196038be87 (patch) | |
| tree | 5168bfdfb3a726b41bde8534746f9f5bdc216313 /drivers/net/wireless/orinoco | |
| parent | 9b60b64bfe98b9cc01b21e6126819b11a0f0a971 (diff) | |
| download | op-kernel-dev-1105a13bb8ad29cf83d46989ee462d196038be87.zip op-kernel-dev-1105a13bb8ad29cf83d46989ee462d196038be87.tar.gz | |
orinoco_usb: fix memory leak in ezusb_access_ltv() when device disconnected
If "device is disconnected" check occurs to be true in ezusb_access_ltv(),
it just return -ENODEV. But that means request_context is leaked since
there are no any references to it anymore.
The patch adds a call to ezusb_request_context_put() before return.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/orinoco')
| -rw-r--r-- | drivers/net/wireless/orinoco/orinoco_usb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c b/drivers/net/wireless/orinoco/orinoco_usb.c index 1f9cb55..bdfe637 100644 --- a/drivers/net/wireless/orinoco/orinoco_usb.c +++ b/drivers/net/wireless/orinoco/orinoco_usb.c @@ -881,7 +881,8 @@ static int ezusb_access_ltv(struct ezusb_priv *upriv, if (!upriv->udev) { dbg("Device disconnected"); - return -ENODEV; + retval = -ENODEV; + goto exit; } if (upriv->read_urb->status != -EINPROGRESS) |
