diff options
| author | Arend van Spriel <arend@broadcom.com> | 2013-08-10 12:27:20 +0200 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2013-08-15 16:07:52 -0400 |
| commit | 04779fddeff723cf5afe529e4ed67fc86f25ba37 (patch) | |
| tree | 54b098098de348d01be3e1194c3a6fef25e6b5b2 /drivers/net/wireless/brcm80211/brcmfmac/usb.c | |
| parent | 4061f895088a2825b15312947aedb8574e2d8de5 (diff) | |
| download | op-kernel-dev-04779fddeff723cf5afe529e4ed67fc86f25ba37.zip op-kernel-dev-04779fddeff723cf5afe529e4ed67fc86f25ba37.tar.gz | |
brcmfmac: .txdata() bus callback should not call brcmf_txcomplete()
With firmware-signalling the packet handed to the bus specific driver
layer should not be discarded with brcmf_txcomplete() in the failure
path. Instead only an error is returned and the caller decides what
to do with the packet.
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/brcm80211/brcmfmac/usb.c')
| -rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/usb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/brcm80211/brcmfmac/usb.c index 322cadc..39e01a7 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/usb.c @@ -614,7 +614,6 @@ static int brcmf_usb_tx(struct device *dev, struct sk_buff *skb) return 0; fail: - brcmf_txcomplete(dev, skb, false); return ret; } |
