summaryrefslogtreecommitdiffstats
path: root/drivers/net/wan
diff options
context:
space:
mode:
authorSalva Peiró <speiro@ai2.upv.es>2013-10-16 12:46:50 +0200
committerDavid S. Miller <davem@davemloft.net>2013-10-18 16:04:25 -0400
commit2b13d06c9584b4eb773f1e80bbaedab9a1c344e1 (patch)
tree401bfe11c8f592d0a6927ff0f36b2deda8ef80f6 /drivers/net/wan
parentb8bde1c4f94908ce8e3c0434fb369a00e9217497 (diff)
downloadop-kernel-dev-2b13d06c9584b4eb773f1e80bbaedab9a1c344e1.zip
op-kernel-dev-2b13d06c9584b4eb773f1e80bbaedab9a1c344e1.tar.gz
wanxl: fix info leak in ioctl
The wanxl_ioctl() code fails to initialize the two padding bytes of struct sync_serial_settings after the ->loopback member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Salva Peiró <speiro@ai2.upv.es> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan')
-rw-r--r--drivers/net/wan/wanxl.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index 6a24a5a..4c0a697 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
ifr->ifr_settings.size = size; /* data size wanted */
return -ENOBUFS;
}
+ memset(&line, 0, sizeof(line));
line.clock_type = get_status(port)->clocking;
line.clock_rate = 0;
line.loopback = 0;
OpenPOWER on IntegriCloud