diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-09-05 20:04:05 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-05 20:04:05 -0700 |
commit | adea1ac7effbddbe60a9de6d63462bfe79289e59 (patch) | |
tree | 2461d7d34598a807a5e161ae4cde0136df5619ec /drivers/net/wan/pc300_drv.c | |
parent | 55bc3228ccef255041d697fe55dcc7fe4b37feb6 (diff) | |
download | op-kernel-dev-adea1ac7effbddbe60a9de6d63462bfe79289e59.zip op-kernel-dev-adea1ac7effbddbe60a9de6d63462bfe79289e59.tar.gz |
r8169: fix rx checksum offload
While porting GRO to r8169, I found this driver has a bug in its rx
path.
All skbs given to network stack had their ip_summed set to
CHECKSUM_NONE, while hardware said they had correct TCP/UDP checksums.
The reason is driver sets skb->ip_summed on the original skb before the
copy eventually done by copybreak. The fresh skb gets the ip_summed =
CHECKSUM_NONE value, forcing network stack to recompute checksum, and
preventing my GRO patch to work.
Fix is to make the ip_summed setting after skb copy.
Note : rx_copybreak current value is 16383, so all frames are copied...
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan/pc300_drv.c')
0 files changed, 0 insertions, 0 deletions