summaryrefslogtreecommitdiffstats
path: root/drivers/net/usb
diff options
context:
space:
mode:
authorJussi Kivilinna <jussi.kivilinna@mbnet.fi>2010-06-07 00:56:27 -0700
committerDavid S. Miller <davem@davemloft.net>2010-06-07 00:56:27 -0700
commit9227a46bfbac0516fb7428715a095e1bc59b872a (patch)
tree2306b6f10f51a14b815af079b35bcc5eadd003fb /drivers/net/usb
parent024a07bacf8287a6ddfa83e9d5b951c5e8b4070e (diff)
downloadop-kernel-dev-9227a46bfbac0516fb7428715a095e1bc59b872a.zip
op-kernel-dev-9227a46bfbac0516fb7428715a095e1bc59b872a.tar.gz
asix: check packet size against mtu+ETH_HLEN instead of ETH_FRAME_LEN
Driver checks received packet is too large in asix_rx_fixup() and fails if it is. Problem is that MTU might be set larger than 1500 and asix fails to work correctly with VLAN tagged packets. The check should be 'dev->net->mtu + ETH_HLEN' instead. Tested with AX88772. Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
-rw-r--r--drivers/net/usb/asix.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index 1f802e90..9516f38 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -344,7 +344,7 @@ static int asix_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
return 2;
}
- if (size > ETH_FRAME_LEN) {
+ if (size > dev->net->mtu + ETH_HLEN) {
netdev_err(dev->net, "asix_rx_fixup() Bad RX Length %d\n",
size);
return 0;
OpenPOWER on IntegriCloud