summaryrefslogtreecommitdiffstats
path: root/drivers/net/sungem_phy.c
diff options
context:
space:
mode:
authorRoel Kluin <roel.kluin@gmail.com>2009-02-02 23:19:50 -0800
committerDavid S. Miller <davem@davemloft.net>2009-02-02 23:19:50 -0800
commitff01b9163655ace76b29b7ff2f56b25c32f795da (patch)
treecde3ed89cb379d5e74216cff08077a38f2efd8af /drivers/net/sungem_phy.c
parent46578a6913e6f5e69229561736b94c18c2e88ae4 (diff)
downloadop-kernel-dev-ff01b9163655ace76b29b7ff2f56b25c32f795da.zip
op-kernel-dev-ff01b9163655ace76b29b7ff2f56b25c32f795da.tar.gz
cassini/sungem: limit reaches -1, but 0 tested
while (limit--) if (test()) break; if (limit <= 0) goto test_failed; In the last iteration, limit is decremented after the test to 0. If just thereafter test() succeeds and a break occurs, the goto still occurs because limit is 0. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sungem_phy.c')
-rw-r--r--drivers/net/sungem_phy.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
index 61843fd..78f8cee 100644
--- a/drivers/net/sungem_phy.c
+++ b/drivers/net/sungem_phy.c
@@ -79,7 +79,7 @@ static int reset_one_mii_phy(struct mii_phy* phy, int phy_id)
udelay(100);
- while (limit--) {
+ while (--limit) {
val = __phy_read(phy, phy_id, MII_BMCR);
if ((val & BMCR_RESET) == 0)
break;
OpenPOWER on IntegriCloud