summaryrefslogtreecommitdiffstats
path: root/drivers/net/smsc9420.c
diff options
context:
space:
mode:
authorSteve Glendinning <steve.glendinning@smsc.com>2009-02-16 07:46:06 +0000
committerDavid S. Miller <davem@davemloft.net>2009-02-20 00:35:08 -0800
commit9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b (patch)
treed0262254d16becb4867cf6883108b3998891e123 /drivers/net/smsc9420.c
parent494ef10ebacc23679350a17483879366d8bafebd (diff)
downloadop-kernel-dev-9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b.zip
op-kernel-dev-9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b.tar.gz
smsc9420: fix another postfixed timeout
Roel Kluin recently fixed several instances where variables reach -1, but 0 is tested afterwards. This patch fixes another, so the timeout will be correctly detected and a warning printed. Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/smsc9420.c')
-rw-r--r--drivers/net/smsc9420.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/smsc9420.c b/drivers/net/smsc9420.c
index a1e4b38..83938e1 100644
--- a/drivers/net/smsc9420.c
+++ b/drivers/net/smsc9420.c
@@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op)
do {
msleep(1);
e2cmd = smsc9420_reg_read(pd, E2P_CMD);
- } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--));
+ } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout));
if (!timeout) {
smsc_info(HW, "TIMED OUT");
OpenPOWER on IntegriCloud