diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2012-07-02 10:33:08 +0300 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-07-09 09:07:22 +0930 |
| commit | 9c378abc5c0c6fc8e3acf5968924d274503819b3 (patch) | |
| tree | a818c1e2cda775a8f52e11d35ae8f9b02cfd2522 /drivers/net/slip/slip.h | |
| parent | 02edf6abe01610a5fb379df442de3c837ad99467 (diff) | |
| download | op-kernel-dev-9c378abc5c0c6fc8e3acf5968924d274503819b3.zip op-kernel-dev-9c378abc5c0c6fc8e3acf5968924d274503819b3.tar.gz | |
virtio-balloon: fix add/get API use
Since ee7cd8981e15bcb365fc762afe3fc47b8242f630 'virtio: expose added
descriptors immediately.', in virtio balloon virtqueue_get_buf might
now run concurrently with virtqueue_kick. I audited both and this
seems safe in practice but this is not guaranteed by the API.
Additionally, a spurious interrupt might in theory make
virtqueue_get_buf run in parallel with virtqueue_add_buf, which is
racy.
While we might try to protect against spurious callbacks it's
easier to fix the driver: balloon seems to be the only one
(mis)using the API like this, so let's just fix balloon.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (removed unused var)
Diffstat (limited to 'drivers/net/slip/slip.h')
0 files changed, 0 insertions, 0 deletions
