summaryrefslogtreecommitdiffstats
path: root/drivers/net/s2io.h
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2009-08-25 08:52:00 +0000
committerDavid S. Miller <davem@davemloft.net>2009-08-30 22:35:11 -0700
commit9e39f7c5b311a306977c5471f9e2ce4c456aa038 (patch)
tree3d76af2016c6991ec0d3785eb0890959d73b7ae2 /drivers/net/s2io.h
parent82c2d02356229c66daa6b6e51f8da559327b87b0 (diff)
downloadop-kernel-dev-9e39f7c5b311a306977c5471f9e2ce4c456aa038.zip
op-kernel-dev-9e39f7c5b311a306977c5471f9e2ce4c456aa038.tar.gz
s2io: Generate complete messages using single line DBG_PRINTs
Single line log messages should be emitted by a single call where possible. Converted multiple calls to DBG_PRINT to single call form. Removed "s2io:" preface from DBG_PRINTs. The DBG_PRINT macro now emits a log level and is surrounded by a do {...} while (0) All s2io log output is now prefaced with KBUILD_MODNAME ": " via pr_fmt. The DBG_PRINT macro should probably be converted to use the dev_<level> form eventually. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/s2io.h')
-rw-r--r--drivers/net/s2io.h5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
index d5c5be6..47c36e0 100644
--- a/drivers/net/s2io.h
+++ b/drivers/net/s2io.h
@@ -64,7 +64,10 @@ enum {
static int debug_level = ERR_DBG;
/* DEBUG message print. */
-#define DBG_PRINT(dbg_level, args...) if(!(debug_level<dbg_level)) printk(args)
+#define DBG_PRINT(dbg_level, fmt, args...) do { \
+ if (dbg_level >= debug_level) \
+ pr_info(fmt, ##args); \
+ } while (0)
/* Protocol assist features of the NIC */
#define L3_CKSUM_OK 0xFFFF
OpenPOWER on IntegriCloud