diff options
author | Gerrit Renker <gerrit@erg.abdn.ac.uk> | 2008-05-17 08:35:36 +0100 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-05-22 06:19:18 -0400 |
commit | 5a0a92e67b5009a71e011658da04fb92dad8961f (patch) | |
tree | 972c08baf56fbd8abfcf5d5854567e846b322e80 /drivers/net/phy | |
parent | 789585e968f07653a29a9e829aed20386043636c (diff) | |
download | op-kernel-dev-5a0a92e67b5009a71e011658da04fb92dad8961f.zip op-kernel-dev-5a0a92e67b5009a71e011658da04fb92dad8961f.tar.gz |
[SC92031] Using padto turned driver into an IPv6-only interface
IPv4 would work with this driver only with static arp table entries,
the patch reverts a padto introduced in
commit 26a17b7bbb36a8552d531bc1ad08472fb5aa3007
sc92031: start transmit return value bugfix
The padto does not work because the driver code evaluates `len' later on and
there are cases where skb->len is not updated accordingly.
This was observed with ARP frames (skb->len = 42 bytes, !skb_cloned(),
skb_tailroom = 84 bytes). Then in skb_pad(), the first condition is true, where
skb->len is not updated. As a consequence, the driver uses 42 bytes instead of
the 60 bytes, and the ARP frame never makes it onto the wire.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/phy')
0 files changed, 0 insertions, 0 deletions