diff options
| author | Alexander Duyck <alexander.h.duyck@intel.com> | 2014-09-08 11:25:34 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-09-08 14:24:35 -0700 |
| commit | db91b724b53b1cfd0e258d7cf3a03a062a89fe2d (patch) | |
| tree | 1cbfb6018f7609dc4cc1e5c0fd200d931287eee8 /drivers/net/phy/dp83640.c | |
| parent | eb84d6b60491a3ca3d90d62ee5346b007770d40d (diff) | |
| download | op-kernel-dev-db91b724b53b1cfd0e258d7cf3a03a062a89fe2d.zip op-kernel-dev-db91b724b53b1cfd0e258d7cf3a03a062a89fe2d.tar.gz | |
dp83640: Make use of skb_queue_purge instead of reimplementing the code
This change makes it so that dp83640_remove can use skb_queue_purge
instead of looping through itself to flush any entries out of the queue.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/dp83640.c')
| -rw-r--r-- | drivers/net/phy/dp83640.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 87648b3..2954052 100644 --- a/drivers/net/phy/dp83640.c +++ b/drivers/net/phy/dp83640.c @@ -1136,7 +1136,6 @@ static void dp83640_remove(struct phy_device *phydev) struct dp83640_clock *clock; struct list_head *this, *next; struct dp83640_private *tmp, *dp83640 = phydev->priv; - struct sk_buff *skb; if (phydev->addr == BROADCAST_ADDR) return; @@ -1144,11 +1143,8 @@ static void dp83640_remove(struct phy_device *phydev) enable_status_frames(phydev, false); cancel_work_sync(&dp83640->ts_work); - while ((skb = skb_dequeue(&dp83640->rx_queue)) != NULL) - kfree_skb(skb); - - while ((skb = skb_dequeue(&dp83640->tx_queue)) != NULL) - kfree_skb(skb); + skb_queue_purge(&dp83640->rx_queue); + skb_queue_purge(&dp83640->tx_queue); clock = dp83640_clock_get(dp83640->clock); |
