diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2007-09-26 22:40:08 -0700 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 16:52:55 -0700 |
commit | f4618d39a34dab316090263b42cd8799f31ce277 (patch) | |
tree | 75db202b492da1797145fde455b0c4c89cf41767 /drivers/net/loopback.c | |
parent | 32db927686f6d475fc05b6229f82ed576c0c8096 (diff) | |
download | op-kernel-dev-f4618d39a34dab316090263b42cd8799f31ce277.zip op-kernel-dev-f4618d39a34dab316090263b42cd8799f31ce277.tar.gz |
[NETNS]: Simplify the network namespace list locking rules.
Denis V. Lunev <den@sw.ru> noticed that the locking rules
for the network namespace list are over complicated and broken.
In particular the current register_netdev_notifier currently
does not take any lock making the for_each_net iteration racy
with network namespace creation and destruction. Oops.
The fact that we need to use for_each_net in rtnl_unlock() when
the rtnetlink support becomes per network namespace makes designing
the proper locking tricky. In addition we need to be able to call
rtnl_lock() and rtnl_unlock() when we have the net_mutex held.
After thinking about it and looking at the alternatives carefully
it looks like the simplest and most maintainable solution is
to remove net_list_mutex altogether, and to use the rtnl_mutex instead.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/loopback.c')
0 files changed, 0 insertions, 0 deletions