summaryrefslogtreecommitdiffstats
path: root/drivers/net/irda
diff options
context:
space:
mode:
authorJos-Vicente Gilabert <josevteg@gmail.com>2009-01-14 20:55:00 -0800
committerDavid S. Miller <davem@davemloft.net>2009-01-14 20:55:00 -0800
commit2950e952920811be465ec95c6b56f03dc66a05c0 (patch)
tree6adf469d250084d31824282cfec874a7e074ba94 /drivers/net/irda
parent6f70340698333f14b1d9c9e913c5de8f66b72c55 (diff)
downloadop-kernel-dev-2950e952920811be465ec95c6b56f03dc66a05c0.zip
op-kernel-dev-2950e952920811be465ec95c6b56f03dc66a05c0.tar.gz
drivers/net/irda/irda-usb.c: fix buffer overflow
Taken from http://bugzilla.kernel.org/show_bug.cgi?id=12397 We're doing an sprintf of an 11-char string into an 11-char buffer. Whoops. It breaks firmware uploading. Reported-by: Jos-Vicente Gilabert <josevteg@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/irda')
-rw-r--r--drivers/net/irda/irda-usb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c
index 29118f5..3a22dc4 100644
--- a/drivers/net/irda/irda-usb.c
+++ b/drivers/net/irda/irda-usb.c
@@ -1073,7 +1073,7 @@ static int stir421x_patch_device(struct irda_usb_cb *self)
{
unsigned int i;
int ret;
- char stir421x_fw_name[11];
+ char stir421x_fw_name[12];
const struct firmware *fw;
const unsigned char *fw_version_ptr; /* pointer to version string */
unsigned long fw_version = 0;
OpenPOWER on IntegriCloud