summaryrefslogtreecommitdiffstats
path: root/drivers/net/irda/sa1100_ir.c
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2012-10-05 11:33:05 +0000
committerDavid S. Miller <davem@davemloft.net>2012-10-07 14:37:11 -0400
commitcbd841ca91b4f87d62263f8d86af1b14a745c413 (patch)
tree948fcca23623df7aeb97a7bf846f1c41a6cc7eae /drivers/net/irda/sa1100_ir.c
parent6734011f3c9a17070f157656f8b15e051e37aee1 (diff)
downloadop-kernel-dev-cbd841ca91b4f87d62263f8d86af1b14a745c413.zip
op-kernel-dev-cbd841ca91b4f87d62263f8d86af1b14a745c413.tar.gz
drivers/net/irda/pxaficp_ir.c: fix error return code
The function pxa_irda_probe() return 0 for success and negative value for most of its internal tests failures. There is one exception that is error case going to err_mem_3:. For this error case, the function abort its success execution path, but returns non negative value, making it difficult for a caller function to notice the error. This patch fixes the error case that do not return negative value. This was found by Coccinelle, but the code change was made by hand. This patch is not robot generated. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/irda/sa1100_ir.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud