summaryrefslogtreecommitdiffstats
path: root/drivers/net/hamradio
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2013-03-27 18:25:04 +0000
committerDavid S. Miller <davem@davemloft.net>2013-03-27 14:30:55 -0400
commit429a22ca39e531d9f8bacac1f81f7207909bcbd2 (patch)
tree32193c308f165af8f7b4c1496110c70233ad146e /drivers/net/hamradio
parente2a553dbf18a5177fdebe29495c32a8e7fd3a4db (diff)
downloadop-kernel-dev-429a22ca39e531d9f8bacac1f81f7207909bcbd2.zip
op-kernel-dev-429a22ca39e531d9f8bacac1f81f7207909bcbd2.tar.gz
yam: remove redundant null check on dev
yam_open has a redundant null check on null, it will never be called with dev == NULL. Remove this redundant check. This also cleans up a smatch warning: drivers/net/hamradio/yam.c:869 yam_open() warn: variable dereferenced before check 'dev' (see line 867) Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hamradio')
-rw-r--r--drivers/net/hamradio/yam.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 4cf8f10..b2d863f 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -866,7 +866,7 @@ static int yam_open(struct net_device *dev)
printk(KERN_INFO "Trying %s at iobase 0x%lx irq %u\n", dev->name, dev->base_addr, dev->irq);
- if (!dev || !yp->bitrate)
+ if (!yp->bitrate)
return -ENXIO;
if (!dev->base_addr || dev->base_addr > 0x1000 - YAM_EXTENT ||
dev->irq < 2 || dev->irq > 15) {
OpenPOWER on IntegriCloud