summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethoc.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-07-27 06:13:30 +0000
committerDavid S. Miller <davem@davemloft.net>2009-07-27 11:35:28 -0700
commit463889e27e6f4f097374a6c9de5611f520766dad (patch)
tree80c5d38c591e85fe004b571c84414d5603726b02 /drivers/net/ethoc.c
parentf004ec728bff3cf924ffc19387baca503cd73b01 (diff)
downloadop-kernel-dev-463889e27e6f4f097374a6c9de5611f520766dad.zip
op-kernel-dev-463889e27e6f4f097374a6c9de5611f520766dad.tar.gz
drivers/net: Correct redundant test
res has already been tested. It seems that this test should be on the recently returned value mmio. A simplified version of the semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; expression E; @@ if (x == NULL || ...) { ... when forall return ...; } ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) ( *x == NULL | *x != NULL ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethoc.c')
-rw-r--r--drivers/net/ethoc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
index ceb6a9c..4dbe5f1 100644
--- a/drivers/net/ethoc.c
+++ b/drivers/net/ethoc.c
@@ -894,7 +894,7 @@ static int ethoc_probe(struct platform_device *pdev)
mmio = devm_request_mem_region(&pdev->dev, res->start,
res->end - res->start + 1, res->name);
- if (!res) {
+ if (!mmio) {
dev_err(&pdev->dev, "cannot request I/O memory space\n");
ret = -ENXIO;
goto free;
OpenPOWER on IntegriCloud