diff options
| author | Mitch Williams <mitch.a.williams@intel.com> | 2014-02-13 03:48:52 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-02-13 17:27:30 -0500 |
| commit | e8106ebe2feb29b2790ba4ad4494b8f6a31126cc (patch) | |
| tree | 43827a620312f95c68425a0757b1b75506457805 /drivers/net/ethernet | |
| parent | e1dfee8e64c2b30e123080e87c5528fae94f5440 (diff) | |
| download | op-kernel-dev-e8106ebe2feb29b2790ba4ad4494b8f6a31126cc.zip op-kernel-dev-e8106ebe2feb29b2790ba4ad4494b8f6a31126cc.tar.gz | |
i40evf: change type of flags variable
As pointed out by Dan Carpenter (from Oracle), the flags variable is
declared as a 64-bit long but all of the flags are defined as u32,
which may lead to unintended consequences. Fix this by declaring flags
as u32 (since we don't need any more than about a dozen flags right
now), and remove the volatile qualifier, since it's unnecessary and
just makes checkpatch cry.
Change-ID: I137d3bb1842bf7e9456b5929ca54e3b0ed45dcab
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
CC: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/intel/i40evf/i40evf.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h index 696c9d1..5e0a344 100644 --- a/drivers/net/ethernet/intel/i40evf/i40evf.h +++ b/drivers/net/ethernet/intel/i40evf/i40evf.h @@ -205,7 +205,7 @@ struct i40evf_adapter { int num_msix_vectors; struct msix_entry *msix_entries; - volatile unsigned long flags; + u32 flags; #define I40EVF_FLAG_RX_CSUM_ENABLED (u32)(1) #define I40EVF_FLAG_RX_1BUF_CAPABLE (u32)(1 << 1) #define I40EVF_FLAG_RX_PS_CAPABLE (u32)(1 << 2) |
