diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2011-09-02 23:23:00 +0100 |
|---|---|---|
| committer | Ben Hutchings <bhutchings@solarflare.com> | 2012-01-27 00:10:45 +0000 |
| commit | 1cb345220f135dcca24f01cc04cbb97a8242d419 (patch) | |
| tree | 059ec907cd50bd10114bd942d0ffbfa7fd080aa2 /drivers/net/ethernet/sfc/mcdi_mac.c | |
| parent | 788ec41cc843f12e8d0eba5f2b37af18b76654a5 (diff) | |
| download | op-kernel-dev-1cb345220f135dcca24f01cc04cbb97a8242d419.zip op-kernel-dev-1cb345220f135dcca24f01cc04cbb97a8242d419.tar.gz | |
sfc: Hold efx_nic::stats_lock while reading efx_nic::mac_stats
efx_nic::stats_lock is used to serialise stats updates, but each
reader was dropping it before it finished reading efx_nic::mac_stats.
If there were concurrent stats reads using procfs, or one using procfs
and one using ethtool, an update could race with a read. On a 32-bit
system, the reader could see word-tearing of 64-bit stats (32 bits of
the old value and 32 bits of the new).
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Diffstat (limited to 'drivers/net/ethernet/sfc/mcdi_mac.c')
0 files changed, 0 insertions, 0 deletions
