diff options
author | Eric Dumazet <edumazet@google.com> | 2017-05-23 12:38:35 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-05-24 16:29:57 -0400 |
commit | ce682ef6e3e019f98cafbdc7058668e0ea8f4a13 (patch) | |
tree | 771905210d14b2a9fdecfb27c4f2f4f8ecbb2743 /drivers/net/ethernet/mellanox | |
parent | 64dba236a15770af1e07f90f23a54789c9f9a3ba (diff) | |
download | op-kernel-dev-ce682ef6e3e019f98cafbdc7058668e0ea8f4a13.zip op-kernel-dev-ce682ef6e3e019f98cafbdc7058668e0ea8f4a13.tar.gz |
tcp: fix TCP_SYNCNT flakes
After the mentioned commit, some of our packetdrill tests became flaky.
TCP_SYNCNT socket option can limit the number of SYN retransmits.
retransmits_timed_out() has to compare times computations based on
local_clock() while timers are based on jiffies. With NTP adjustments
and roundings we can observe 999 ms delay for 1000 ms timers.
We end up sending one extra SYN packet.
Gimmick added in commit 6fa12c850314 ("Revert Backoff [v3]: Calculate
TCP's connection close threshold as a time value") makes no
real sense for TCP_SYN_SENT sockets where no RTO backoff can happen at
all.
Lets use a simpler logic for TCP_SYN_SENT sockets and remove @syn_set
parameter from retransmits_timed_out()
Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox')
0 files changed, 0 insertions, 0 deletions