diff options
author | Eric Dumazet <edumazet@google.com> | 2017-02-23 15:22:43 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-02-26 15:39:43 -0500 |
commit | 47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf (patch) | |
tree | 3b76e771fa632c766ec0b4b25a6fdbbb01fa2ce1 /drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | |
parent | 8b1bb92bb6f6f5b05379c39f0e3bbf4f359e9298 (diff) | |
download | op-kernel-dev-47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf.zip op-kernel-dev-47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf.tar.gz |
net/mlx4_en: fix overflow in mlx4_en_init_timestamp()
The cited commit makes a great job of finding optimal shift/multiplier
values assuming a 10 seconds wrap around, but forgot to change the
overflow_period computation.
It overflows in cyclecounter_cyc2ns(), and the final result is 804 ms,
which is silly.
Lets simply use 5 seconds, no need to recompute this, given how it is
supposed to work.
Later, we will use a timer instead of a work queue, since the new RX
allocation schem will no longer need mlx4_en_recover_from_oom() and the
service_task firing every 250 ms.
Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value according to HW frequency")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Cc: Eugenia Emantayev <eugenia@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx4/mlx4_en.h')
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 4941b69..3629ce1 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h @@ -430,7 +430,6 @@ struct mlx4_en_dev { seqlock_t clock_lock; struct timecounter clock; unsigned long last_overflow_check; - unsigned long overflow_period; struct ptp_clock *ptp_clock; struct ptp_clock_info ptp_clock_info; struct notifier_block nb; |