diff options
| author | John Fastabend <john.r.fastabend@intel.com> | 2014-01-16 02:30:05 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-01-16 15:34:24 -0800 |
| commit | 8f4c5c9fb87aa113f33ddeb4028fb0de8e18311d (patch) | |
| tree | dad6cbc28f3e956635ba1ce9b31f03af0587aea4 /drivers/net/ethernet/intel/ixgbe | |
| parent | 0864c158836c2d0edb61f7128475e192b09bc851 (diff) | |
| download | op-kernel-dev-8f4c5c9fb87aa113f33ddeb4028fb0de8e18311d.zip op-kernel-dev-8f4c5c9fb87aa113f33ddeb4028fb0de8e18311d.tar.gz | |
ixgbe: reinit_locked() should be called with rtnl_lock
ixgbe_service_task() is calling ixgbe_reinit_locked() without
the rtnl_lock being held. This is because it is being called
from a worker thread and not a rtnl netlink or dcbnl path.
Add rtnl_{un}lock() semantics. I found this during code review.
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/ixgbe')
| -rw-r--r-- | drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 3ca59d2..b445ad1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -6392,7 +6392,9 @@ static void ixgbe_reset_subtask(struct ixgbe_adapter *adapter) netdev_err(adapter->netdev, "Reset adapter\n"); adapter->tx_timeout_count++; + rtnl_lock(); ixgbe_reinit_locked(adapter); + rtnl_unlock(); } /** |
