summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/i40e
diff options
context:
space:
mode:
authorJacob Keller <jacob.e.keller@intel.com>2016-12-12 15:44:09 -0800
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2017-02-18 20:35:35 -0800
commit03aa268b146127361c206fe3942add2adf6ce1d7 (patch)
tree1a10ac3c6fa9d74134e969d237168eac4e36d96b /drivers/net/ethernet/intel/i40e
parent1d68005db4e72082f3e537d6c0cf831a71a7e2ee (diff)
downloadop-kernel-dev-03aa268b146127361c206fe3942add2adf6ce1d7.zip
op-kernel-dev-03aa268b146127361c206fe3942add2adf6ce1d7.tar.gz
i40e: remove unnecessary call to i40e_update_link_info
This call is made just prior to running i40e_link_event. In i40e_link_event, we set hw->phy.get_link_info to true just prior to calling i40e_get_link_status, which conveniently runs i40e_update_link_info for us. Thus, we are running i40e_update_link_info twice, which seems like something we don't need to do... Change-ID: I36467a570f44b7546d218c99e134ff97c2709315 Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40e')
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_main.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index e9335af..a6dca58 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -10761,7 +10761,6 @@ static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit)
i40e_pf_config_rss(pf);
/* fill in link information and enable LSE reporting */
- i40e_update_link_info(&pf->hw);
i40e_link_event(pf);
/* Initialize user-specific link properties */
OpenPOWER on IntegriCloud