diff options
| author | Muhammad Falak R Wani <falakreyaz@gmail.com> | 2016-05-19 19:22:49 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-05-20 19:50:07 -0400 |
| commit | 7c542772cc5ff061ec3d06658f5d36304bcd5395 (patch) | |
| tree | 891d76e486f386e451f60f02fe3a970d787c814a /drivers/net/ethernet/cavium | |
| parent | e27f4a942a0ee4b84567a3c6cfa84f273e55cbb7 (diff) | |
| download | op-kernel-dev-7c542772cc5ff061ec3d06658f5d36304bcd5395.zip op-kernel-dev-7c542772cc5ff061ec3d06658f5d36304bcd5395.tar.gz | |
net:liquidio: use kmemdup
Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/cavium')
| -rw-r--r-- | drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index f67641a..8e23e3f 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, const u8 *data, snprintf(oct->fw_info.liquidio_firmware_version, 32, "LIQUIDIO: %s", h->version); - buffer = kmalloc(size, GFP_KERNEL); + buffer = kmemdup(data, size, GFP_KERNEL); if (!buffer) return -ENOMEM; - memcpy(buffer, data, size); - p = buffer + sizeof(struct octeon_firmware_file_header); /* load all images */ |
