summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
diff options
context:
space:
mode:
authorMerav Sicron <meravs@broadcom.com>2012-08-27 03:26:19 +0000
committerDavid S. Miller <davem@davemloft.net>2012-08-30 13:36:46 -0400
commit26614ba5445fe31a69068a5e94266fa08b4ee345 (patch)
treef2c3ddd616e9cd031446d25c1e5e29649be7b0e3 /drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
parentc5ae7d41927dbd208c885d4794e30617ad6cdf12 (diff)
downloadop-kernel-dev-26614ba5445fe31a69068a5e94266fa08b4ee345.zip
op-kernel-dev-26614ba5445fe31a69068a5e94266fa08b4ee345.tar.gz
bnx2x: Move netif_napi_add to the open call
Move netif_napi_add for all queues from the probe call to the open call, to avoid the case that napi objects are added for queues that may eventually not be initialized and activated. With the former behavior, the driver could crash when netpoll was calling ndo_poll_controller. Signed-off-by: Merav Sicron <meravs@broadcom.com> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com> Signed-off-by: Eilon Greenstein <eilong@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bnx2x/bnx2x.h')
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x.h3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
index 463b9ec..6d1a24a 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
@@ -1708,9 +1708,6 @@ struct bnx2x_func_init_params {
continue; \
else
-#define for_each_napi_rx_queue(bp, var) \
- for ((var) = 0; (var) < bp->num_napi_queues; (var)++)
-
/* Skip OOO FP */
#define for_each_tx_queue(bp, var) \
for ((var) = 0; (var) < BNX2X_NUM_QUEUES(bp); (var)++) \
OpenPOWER on IntegriCloud