diff options
author | Gavin Shan <gwshan@linux.vnet.ibm.com> | 2016-05-23 11:58:28 +1000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-05-24 14:47:19 -0700 |
commit | 3275c0c6c522ab04afa14f80efdac6213c3883d6 (patch) | |
tree | d0f1a33bcf739e4cd444b30b73b5dd53dcd77541 /drivers/net/ethernet/altera/altera_tse_main.c | |
parent | 252f3f5a1189a7f6c309d8e4ff1c4c1888a27f13 (diff) | |
download | op-kernel-dev-3275c0c6c522ab04afa14f80efdac6213c3883d6.zip op-kernel-dev-3275c0c6c522ab04afa14f80efdac6213c3883d6.tar.gz |
net/qlge: Avoids recursive EEH error
One timer, whose handler keeps reading on MMIO register for EEH
core to detect error in time, is started when the PCI device driver
is loaded. MMIO register can't be accessed during PE reset in EEH
recovery. Otherwise, the unexpected recursive error is triggered.
The timer isn't closed that time if the interface isn't brought
up. So the unexpected recursive error is seen during EEH recovery
when the interface is down.
This avoids the unexpected recursive EEH error by closing the timer
in qlge_io_error_detected() before EEH PE reset unconditionally. The
timer is started unconditionally after EEH PE reset in qlge_io_resume().
Also, the timer should be closed unconditionally when the device is
removed from the system permanently in qlge_io_error_detected().
Reported-by: Shriya R. Kulkarni <shriyakul@in.ibm.com>
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/altera/altera_tse_main.c')
0 files changed, 0 insertions, 0 deletions