diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2016-01-10 20:43:49 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-01-11 00:00:34 -0500 |
| commit | 713d40248bde50fba40c5bf1b5dde6d5df02cfd0 (patch) | |
| tree | eec2d3f1be60506eb4afc04136d0917de7e3f78f /drivers/net/ethernet/adi | |
| parent | 50ee63824f5e0702da9909b989cdda96a2128afb (diff) | |
| download | op-kernel-dev-713d40248bde50fba40c5bf1b5dde6d5df02cfd0.zip op-kernel-dev-713d40248bde50fba40c5bf1b5dde6d5df02cfd0.tar.gz | |
net: bfin_mac: Use phy_find_first() instead of open-coding it
Use phy_find_first() to find the first phy device instead of
open-coding it.
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/adi')
| -rw-r--r-- | drivers/net/ethernet/adi/bfin_mac.c | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c index 5ddfd0e..74139cb 100644 --- a/drivers/net/ethernet/adi/bfin_mac.c +++ b/drivers/net/ethernet/adi/bfin_mac.c @@ -380,9 +380,8 @@ static void bfin_mac_adjust_link(struct net_device *dev) static int mii_probe(struct net_device *dev, int phy_mode) { struct bfin_mac_local *lp = netdev_priv(dev); - struct phy_device *phydev = NULL; + struct phy_device *phydev; unsigned short sysctl; - int i; u32 sclk, mdc_div; /* Enable PHY output early */ @@ -396,19 +395,7 @@ static int mii_probe(struct net_device *dev, int phy_mode) sysctl = (sysctl & ~MDCDIV) | SET_MDCDIV(mdc_div); bfin_write_EMAC_SYSCTL(sysctl); - /* search for connected PHY device */ - for (i = 0; i < PHY_MAX_ADDR; ++i) { - struct phy_device *const tmp_phydev = - mdiobus_get_phy(lp->mii_bus, i); - - if (!tmp_phydev) - continue; /* no PHY here... */ - - phydev = tmp_phydev; - break; /* found it */ - } - - /* now we are supposed to have a proper phydev, to attach to... */ + phydev = phy_find_first(lp->mii_bus); if (!phydev) { netdev_err(dev, "no phy device found\n"); return -ENODEV; |
