summaryrefslogtreecommitdiffstats
path: root/drivers/net/e1000e
diff options
context:
space:
mode:
authorAdrian Bunk <bunk@kernel.org>2007-10-15 14:02:21 -0700
committerJeff Garzik <jeff@garzik.org>2007-10-16 21:10:27 -0400
commite265522ca7d7a0cfa24aa2c811d22a1764a90783 (patch)
treeb9f5c851e691a03f402b78a38000dbc5b5b079e3 /drivers/net/e1000e
parent121244a7bfbc739a8d6823aa52c074d1766b895f (diff)
downloadop-kernel-dev-e265522ca7d7a0cfa24aa2c811d22a1764a90783.zip
op-kernel-dev-e265522ca7d7a0cfa24aa2c811d22a1764a90783.tar.gz
e1000e: fix error checks
Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@kernel.org> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/e1000e')
-rw-r--r--drivers/net/e1000e/ethtool.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c
index b7a7e2a..ca06c354 100644
--- a/drivers/net/e1000e/ethtool.c
+++ b/drivers/net/e1000e/ethtool.c
@@ -1451,11 +1451,11 @@ static int e1000_loopback_test(struct e1000_adapter *adapter, u64 *data)
}
*data = e1000_setup_desc_rings(adapter);
- if (data)
+ if (*data)
goto out;
*data = e1000_setup_loopback_test(adapter);
- if (data)
+ if (*data)
goto err_loopback;
*data = e1000_run_loopback_test(adapter);
OpenPOWER on IntegriCloud