diff options
| author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2009-04-17 20:44:34 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-04-20 02:00:39 -0700 |
| commit | 9c563d20671e5fbe3045fd79c18b306ccb77b0b6 (patch) | |
| tree | dd9100c60991d5d43c069d588c73bc5ccaf02309 /drivers/net/e1000 | |
| parent | b168dfc51604ec293db16dc4d558043585578a2d (diff) | |
| download | op-kernel-dev-9c563d20671e5fbe3045fd79c18b306ccb77b0b6.zip op-kernel-dev-9c563d20671e5fbe3045fd79c18b306ccb77b0b6.tar.gz | |
e1000e: indicate link down at load
As reported by Andrew Lutomirski <amluto@gmail.com>
All the intel wired ethernet drivers were calling netif_carrier_off
and netif_stop_queue (or variants) before calling register_netdevice
This is incorrect behavior as was pointed out by davem, and causes
ifconfig and friends to report a strange state before first link
after the driver was loaded, since without a netif_carrier_off, the stack
assumes carrier_on, but before register_netdev, netlink messages are not
sent out telling link state.
This apparently confused *some* versions of networkmanager.
Andy tested this for e1000e and confirmed it was working for him.
see thread: http://marc.info/?l=linux-netdev&m=123946479705636&w=2
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andy Lutomirski <amluto@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/e1000')
0 files changed, 0 insertions, 0 deletions
