summaryrefslogtreecommitdiffstats
path: root/drivers/net/e1000
diff options
context:
space:
mode:
authorAndy Gospodarek <andy@greyhouse.net>2008-06-19 17:19:12 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-06-28 10:23:32 -0400
commitb45f87681e2851f0c991a589989daa6a4a351565 (patch)
treee702ff34a8070a30fcf661e2f648198e14363c3a /drivers/net/e1000
parent42bfd33ab7bce7d2abaa8bd968ae9ad0dc9a4771 (diff)
downloadop-kernel-dev-b45f87681e2851f0c991a589989daa6a4a351565.zip
op-kernel-dev-b45f87681e2851f0c991a589989daa6a4a351565.tar.gz
e1000: remove e1000_clean_tx_irq call from e1000_netpoll
The call to e1000_clean_tx_irq in e1000_netpoll can race with the call to e1000_clean_tx_irq in e1000_clean. With a small bit of tweaking to to netpoll_send_skb to simulate a system that was under extreme stress, I was able to reproduce these concurrent calls. This can result in multiple frees to the skbs on the tx ring buffer. Dropping this call from e1000_netpoll should be fine since we can rely on the calls in e1000_clean to do what is needed since napi will poll the hardware just after calling poll_controller. Signed-off-by: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/e1000')
-rw-r--r--drivers/net/e1000/e1000_main.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index b0e2493..311ca26 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -5251,7 +5251,6 @@ e1000_netpoll(struct net_device *netdev)
disable_irq(adapter->pdev->irq);
e1000_intr(adapter->pdev->irq, netdev);
- e1000_clean_tx_irq(adapter, adapter->tx_ring);
#ifndef CONFIG_E1000_NAPI
adapter->clean_rx(adapter, adapter->rx_ring);
#endif
OpenPOWER on IntegriCloud