summaryrefslogtreecommitdiffstats
path: root/drivers/net/can/rcar_can.c
diff options
context:
space:
mode:
authorAndri Yngvason <andri.yngvason@marel.com>2015-01-16 14:30:28 +0000
committerMarc Kleine-Budde <mkl@pengutronix.de>2015-01-20 13:56:53 +0100
commitbe38a6f9f4093b0f1fa9e7d8cb47d588bc117c21 (patch)
tree41a834156d6483c55fa28eccfc208449bff67d95 /drivers/net/can/rcar_can.c
parent0c49087462e8587c12ecfeaf1dd46fdc0ddc4532 (diff)
downloadop-kernel-dev-be38a6f9f4093b0f1fa9e7d8cb47d588bc117c21.zip
op-kernel-dev-be38a6f9f4093b0f1fa9e7d8cb47d588bc117c21.tar.gz
can: move can_stats.bus_off++ from can_bus_off into can_change_state
In order to be able to move the stats increment from can_bus_off() into can_change_state(), the increment had to be moved back into code that was using can_bus_off() but not can_change_state(). As a side-effect, this patch fixes the following bugs: * Redundant call to can_bus_off() in c_can. * Bus-off counted twice in xilinx_can. Signed-off-by: Andri Yngvason <andri.yngvason@marel.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/rcar_can.c')
-rw-r--r--drivers/net/can/rcar_can.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/can/rcar_can.c b/drivers/net/can/rcar_can.c
index 91cd48c..7deb80d 100644
--- a/drivers/net/can/rcar_can.c
+++ b/drivers/net/can/rcar_can.c
@@ -331,6 +331,7 @@ static void rcar_can_error(struct net_device *ndev)
priv->can.state = CAN_STATE_BUS_OFF;
/* Clear interrupt condition */
writeb(~RCAR_CAN_EIFR_BOEIF, &priv->regs->eifr);
+ priv->can.can_stats.bus_off++;
can_bus_off(ndev);
if (skb)
cf->can_id |= CAN_ERR_BUSOFF;
OpenPOWER on IntegriCloud