summaryrefslogtreecommitdiffstats
path: root/drivers/net/can/grcan.c
diff options
context:
space:
mode:
authorMarc Kleine-Budde <mkl@pengutronix.de>2015-07-11 21:16:08 +0200
committerMarc Kleine-Budde <mkl@pengutronix.de>2015-07-15 09:04:27 +0200
commit83537b6fd6c3752bcb578d2bd46312d1e2c4a73a (patch)
tree8c2dd4ded1e212e2190bdbb8adddb348cc54ae4f /drivers/net/can/grcan.c
parent20926d79244de4e9c698ae429fdc1e7e5832b081 (diff)
downloadop-kernel-dev-83537b6fd6c3752bcb578d2bd46312d1e2c4a73a.zip
op-kernel-dev-83537b6fd6c3752bcb578d2bd46312d1e2c4a73a.tar.gz
can: grcan: don't touch skb after netif_rx()
There is no guarantee that the skb is in the same state after calling net_receive_skb() or netif_rx(). It might be freed or reused. Not really harmful as its a read access, except you turn on the proper debugging options which catch a use after free. Cc: Andreas Larsson <andreas@gaisler.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/grcan.c')
-rw-r--r--drivers/net/can/grcan.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c
index e3d7e22..db9538d 100644
--- a/drivers/net/can/grcan.c
+++ b/drivers/net/can/grcan.c
@@ -1216,11 +1216,12 @@ static int grcan_receive(struct net_device *dev, int budget)
cf->data[i] = (u8)(slot[j] >> shift);
}
}
- netif_receive_skb(skb);
/* Update statistics and read pointer */
stats->rx_packets++;
stats->rx_bytes += cf->can_dlc;
+ netif_receive_skb(skb);
+
rd = grcan_ring_add(rd, GRCAN_MSG_SIZE, dma->rx.size);
}
OpenPOWER on IntegriCloud