diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2009-12-18 20:31:56 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-12-18 20:31:56 -0800 |
| commit | 4773a47d8a564633cd80b94df397e91e946893e2 (patch) | |
| tree | 2ac03e9459394f59bd0953a78eb13cd67a6562f2 /drivers/net/can/at91_can.c | |
| parent | 01a1e7ec6c3769dc7c5fde23ebc253c6be5f68eb (diff) | |
| download | op-kernel-dev-4773a47d8a564633cd80b94df397e91e946893e2.zip op-kernel-dev-4773a47d8a564633cd80b94df397e91e946893e2.tar.gz | |
can/at91: don't check platform_get_irq's return value against zero
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true. Better use (int)irq <= 0. Note that a return value of
zero is still handled as error even though this could mean irq0.
This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/can/at91_can.c')
| -rw-r--r-- | drivers/net/can/at91_can.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c index d0ec178..166cc7e 100644 --- a/drivers/net/can/at91_can.c +++ b/drivers/net/can/at91_can.c @@ -1037,7 +1037,7 @@ static int __init at91_can_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); irq = platform_get_irq(pdev, 0); - if (!res || !irq) { + if (!res || irq <= 0) { err = -ENODEV; goto exit_put; } |
