summaryrefslogtreecommitdiffstats
path: root/drivers/net/bonding
diff options
context:
space:
mode:
authorThomas Graf <tgraf@suug.ch>2014-11-27 00:22:33 +0100
committerDavid S. Miller <davem@davemloft.net>2014-11-29 20:46:32 -0800
commitf6c6fda4c9e17940b0a2ba206b0408babfdc930c (patch)
treecfb028e00d9cd1c00df87f5b4cc442a47354c716 /drivers/net/bonding
parent7a5a4f978750756755dc839014e13d1b088ccc8e (diff)
downloadop-kernel-dev-f6c6fda4c9e17940b0a2ba206b0408babfdc930c.zip
op-kernel-dev-f6c6fda4c9e17940b0a2ba206b0408babfdc930c.tar.gz
bond: Check length of IFLA_BOND_ARP_IP_TARGET attributes
Fixes: 7f28fa10 ("bonding: add arp_ip_target netlink support") Reported-by: John Fastabend <john.fastabend@gmail.com> Cc: Scott Feldman <sfeldma@cumulusnetworks.com> Signed-off-by: Thomas Graf <tgraf@suug.ch> Acked-by: John Fastabend <john.r.fastabend@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding')
-rw-r--r--drivers/net/bonding/bond_netlink.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
index c13d83e..45f09a6 100644
--- a/drivers/net/bonding/bond_netlink.c
+++ b/drivers/net/bonding/bond_netlink.c
@@ -225,7 +225,12 @@ static int bond_changelink(struct net_device *bond_dev,
bond_option_arp_ip_targets_clear(bond);
nla_for_each_nested(attr, data[IFLA_BOND_ARP_IP_TARGET], rem) {
- __be32 target = nla_get_be32(attr);
+ __be32 target;
+
+ if (nla_len(attr) < sizeof(target))
+ return -EINVAL;
+
+ target = nla_get_be32(attr);
bond_opt_initval(&newval, (__force u64)target);
err = __bond_opt_set(bond, BOND_OPT_ARP_TARGETS,
OpenPOWER on IntegriCloud